fix for iOS13 + XCode11 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug in RN0.5x.x. or we will run into "Unknown argument type '__attribute__' in method" when start our app. see this post for the bug:facebook#25138 this pr for the fix: https://github.com/facebook/react-native/pull/25146/files
lhong375
requested review from
an-kumar,
nealchandra,
edelventhal and
matthova
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to work with iOS13, we need XCode11. to use XCode11, we need to fix a bug in RN ( < 0.59.8 )
or we will run into error like "Unknown argument type __attribute __ in method" when starting our app.
see this post for the bug:facebook#25138
this pr for the fix: https://github.com/facebook/react-native/pull/25146/files
tested with XCode11, build into iphoneX which I upgrade to use iOS13.
NOTE: I haven't tested with older version of XCode or older version if iOS, but the change seems safe to me.
when can we move back to official release of RN ? we do have another pr:https://github.com/ubiquity6/react-native/pull/1/files fix the same thing, it's just never merged.