Skip to content

Commit

Permalink
targets: remove --zero-copy/-z argument
Browse files Browse the repository at this point in the history
The zero copy feature in ublk driver side is still in-progress, and not
completed yet, so remove the argument first. And we will add it back
after the kernel side feature[1] is merged.

[1] https://lore.kernel.org/linux-block/[email protected]/

That is also the reason why the help command doesn't show zero copy switch.

Signed-off-by: Ming Lei <[email protected]>
  • Loading branch information
ming1 committed Feb 24, 2025
1 parent 3770ea5 commit 0d0e8a3
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions targets/ublksrv_tgt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,6 @@ int ublksrv_parse_std_opts(struct ublksrv_dev_data *data, int *efd, int argc, ch
{ "number", 1, NULL, 'n' },
{ "queues", 1, NULL, 'q' },
{ "depth", 1, NULL, 'd' },
{ "zero_copy", 1, NULL, 'z' },
{ "uring_comp", 1, NULL, 'u' },
{ "need_get_data", 1, NULL, 'g' },
{ "user_recovery", 1, NULL, 'r'},
Expand All @@ -515,7 +514,7 @@ int ublksrv_parse_std_opts(struct ublksrv_dev_data *data, int *efd, int argc, ch

mkpath(data->run_dir);

while ((opt = getopt_long(argc, argv, "-:t:n:d:q:u:g:r:e:i:z",
while ((opt = getopt_long(argc, argv, "-:t:n:d:q:u:g:r:e:i:",
longopts, &option_index)) != -1) {
switch (opt) {
case 'n':
Expand Down

0 comments on commit 0d0e8a3

Please sign in to comment.