feat: ZFS for coreos, GTS version coreos #207
Conversation
chore(ci): Proper Excludes chore: workaround Tar Bug
m2Giles
changed the title
m2Giles
changed the title
Containerfile.common
Outdated
| /tmp/build-kmod-xone.sh | ||
| /tmp/build-kmod-xone.sh && \ | ||
| if grep -q "coreos" <<< "${KERNEL_FLAVOR}"; then \ | ||
| curl -Lo /tmp/zfs-kmod-spec-in.patch "https://raw.githubusercontent.com/ublue-os/ucore-kmods/main/zfs-kmod-spec-in.patch" && \ |
There was a problem hiding this comment.
You shouldn't need this patch because we won't be building older versions
There was a problem hiding this comment.
The patch and logic was still in Ucore. The only reason I'm not just curling Ucore's install script is the rpm-ostree zlib-devel there causing issues with F40. My preference would be to just curl that script and not have to do the figure out which zfs version dance.
There was a problem hiding this comment.
Yep. Understood. We need to cleanup the ucore-kmods version of the script of the also.
build-kmod-zfs.sh
Outdated
| fi | ||
| if [ "${DO_PATCH}" -eq "0" ]; then | ||
| patch -b -uN -i zfs-kmod-spec-in.patch zfs-${ZFS_VERSION}/rpm/generic/zfs-kmod.spec.in | ||
| fi |
There was a problem hiding this comment.
Same as the earlier comment, we don't need this whole patching section because the ZFS versions old enough to need the patch won't even compile on 6.8 or 6.9
There was a problem hiding this comment.
This is still in the Ucore one. As a heads up
chore(ci): Proper Excludes
chore: workaround Tar Bug
Thank you for contributing to the Universal Blue project!
Please read the Contributor's Guide before submitting a pull request.