feat: Pre dx devmode #2036
feat: Pre dx devmode #2036
Conversation
dosubot
bot
added
the
size:M
|
could do with patching with the whole remote dev extension pack but cba |
system_files/desktop/shared/usr/share/ublue-os/just/87-bazzite-devcontainers.just
Show resolved
Hide resolved
|
It might be worth visiting a vscode distrobox instead of layering it for the future. |
Agreed, the problem is viewing the host docker socket so it'd mean a few other steps, obviously in the -dx release it can be a regular package or maybe a bluefin dev could do the flatpak magic? |
|
@mowglixx I think I found one more issue. The .just files are imported manually in the Containerfile. So your custom ujust commands won't work until you add an entry there too |
|
thanks for pointing that out, would have missed that, I've been testing with Pushing the change now. |
|
I have a VM all set up, I'll test as soon as I get a chance. Probably tomorrow sometime. |
|
Thanks, I've been meaning to do the just script for virt-manager today so I might end up doing it myself, I'll drop a message if i do and I'm going to take a look at the image building process for my own image, I've been admiring @HikariKnight 's personal image for a starting point, I've done passthrough before so was good to see some familiar commands in the place it should be. =D |
|
No need for anything virt-manager, it's a flatpak and already done the optimal way here. |
|
I'm going to give this a containerization pass later today, we want to avoid layers at all costs. After that I'll be happy to merge into testing. |
|
no no no, I meant I'm going to run the just script (I fresh installed the other day from cachyOS) to get virt manager all set up so might run the VM to test ^this further myself |
|
ah so this might end up being an early -dx build instead of the layers? |
|
echo was printing null vars from shell |
|
^ Here's docker as a container. I'm going to leave this PR open as a workshop for a potential best-solution for VSCode as well, may also end up being distrobox until DX. |
| if ! grep -q "^docker:" /etc/group; then | ||
| grep '^docker:' /usr/lib/group | sudo tee -a /etc/group > /dev/null |
There was a problem hiding this comment.
are regexp patterns enabled by default?
| if ! grep -q "^docker:" /etc/group; then | |
| grep '^docker:' /usr/lib/group | sudo tee -a /etc/group > /dev/null | |
| if ! grep -qE "^docker:" /etc/group; then | |
| grep -E '^docker:' /usr/lib/group | sudo tee -a /etc/group > /dev/null |
|
Had some time away and started using the flatpak with a remote Ubuntu VM and docker installed not ideal but it's working, I'd like to continue working on this but I'm starting to realise that the DX mode needs to be a rebase like in bluefin due to docker being installed in the image and not requiring extra layers. I'll try to put in some time this weekend learning how make the images work, tbh tho if DX mode is gunna be a rebase it may as well include the vscode package with the extensions installed for Dev containers. |
|
Think flatpak would be overkill in the instance of having purpose installed packages in the base image, maybe there is a licensing issue? |
See #2035