feat: Update VFIO to be bootc compliant #2150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a tool that lists pci devices and which groups they are in, and it lets you use flags to fine tune what you look for and what info you want.
dosubot
bot
added
size:M
tulilirockz
reviewed
Jan 22, 2025
tulilirockz
reviewed
Jan 22, 2025
| options kvmfr static_size_mb=128 | ||
| KVMFR_MODPROBE" | ||
| # Add kvmfr static size karg | ||
| rpm-ostree kargs --append-if-missing="kvmfr.static_size_mb=128" |
There was a problem hiding this comment.
Using the modprobe override here seems like what we should do with bootc, but maybe it just works?
There was a problem hiding this comment.
we probably can and the looking-glass people would prefer it over using rpm-ostree kargs which is unique to fedora atomic, i am just following the change kyle did in bazzite to add the vfio modules to the image. :)
There was a problem hiding this comment.
thinking back at this, unsure if this will require rebuilding the initramfs when the user changes it though which is what we are trying to avoid.
|
putting back to draft as i remembered there is a part i forgot to move over from bazzite, so will work on that later today or in the weekend hopefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be kept as a draft in-case more changes are needed, but from what i can tell, dracut is being run as part of the build process so the vfio modules should be included into initramfs with the image with this inclusion.
the just recipes and the script for kvmfr has been updated to reflect this
also minor changes to heredocs in some recipes to make the just highlighting work for me in vscode when writing this.
I will be making a similar PR to Aurora with the same updates later.