Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): finish sign refactor and limit pr build #96

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented May 5, 2023

First attempt to copy "avoid subshell, sign image with env. var" to this repo was incomplete as this workflow has two distinct build jobs and the second one was missed.

This commit finishes the job, plus prevents the following steps from running in a PR, again, to match the main repo:

  • login to GHCR
  • push to GHCR
  • sign image
  • echo push outputs

First attempt to copy "avoid subshell, sign image with env. var" to this
repo was incomplete as this workflow has two distinct build jobs and the
second one was missed.

This commit finishes the job, plus prevents the following steps from
running in a PR, again, to match the main repo:
- login to GHCR
- push to GHCR
- sign image
- echo push outputs
@castrojo castrojo enabled auto-merge May 5, 2023 17:43
@castrojo castrojo disabled auto-merge May 5, 2023 17:56
@castrojo castrojo merged commit 93fa3bd into main May 5, 2023
@castrojo castrojo deleted the no-sign-in-pr branch May 5, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants