feat: extend title screen to include additional actions #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will start cmd in host if container does not have cmd
Reidond
changed the title
marcoceppi
requested changes
Mar 26, 2023
|
Hello! Thanks for tackling this - I really like your approach. I had a few nits around using fstrings instead of format. As for the changes to use plugin registry vs hard-coded run was more to allow flexibility of future plugins and follow the more explicit |
Co-authored-by: Marco Ceppi <[email protected]>
|
Hi, updated PR with taking in cosideration all suggestions. Thank you for this great work! |
marcoceppi
approved these changes
Mar 27, 2023
marcoceppi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44