Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gsettings.dart to 0.2+ #183

Closed
Feichtmeier opened this issue Dec 12, 2021 · 1 comment · Fixed by #191
Closed

Upgrade gsettings.dart to 0.2+ #183

Feichtmeier opened this issue Dec 12, 2021 · 1 comment · Fixed by #191
Assignees
@jpnurmi
Labels
feature / enhancement Needs implementation

Comments

@Feichtmeier
Copy link
Member

The package has been completely reworked. Updating to 0.2+ will most likely fix #182
as suggested here by JP: canonical/gsettings.dart#22 (comment)
@Feichtmeier Feichtmeier added the bug Something isn't working label Dec 12, 2021
@Feichtmeier Feichtmeier added feature / enhancement Needs implementation and removed bug Something isn't working labels Dec 12, 2021
@jpnurmi jpnurmi self-assigned this Dec 12, 2021
@jpnurmi
Copy link
Contributor

jpnurmi commented Dec 12, 2021

I can help with this. 🙂 There are some fixes needed in gsettings.dart 0.2 too.

jpnurmi added a commit to jpnurmi/settings that referenced this issue Dec 12, 2021
@jpnurmi
Upgrade from Dart 2.12 to 2.15
d7d4161 
Dart 2.15 has built-in string <-> enum conversions, which comes handy
when migrating from GSettings 0.1 to 0.2 (ubuntu-flutter-community#183).

https://medium.com/dartlang/dart-2-15-7e7a598e508a#107a
@jpnurmi jpnurmi mentioned this issue Dec 12, 2021
Merged
jpnurmi added a commit to jpnurmi/settings that referenced this issue Dec 12, 2021
@jpnurmi
Upgrade from Dart 2.12 to 2.15
6e1fb2d 
Dart 2.15 has built-in string <-> enum conversions, which comes handy
when migrating from GSettings 0.1 to 0.2 (ubuntu-flutter-community#183).

https://medium.com/dartlang/dart-2-15-7e7a598e508a#107a
jpnurmi added a commit to jpnurmi/settings that referenced this issue Dec 12, 2021
@jpnurmi
Abstract away GSettings
8f648f8 
This is a preparation step for ubuntu-flutter-community#183 i.e. migrating from GSettings 0.1
to 0.2.

GSettings 0.1 and 0.2 are vastly different because the FFI-based 0.1 is
synchronous, whereas the D-Bus-based 0.2 is asynchronous. Furthermore,
0.1 has separate getters for different primitive types, whereas 0.2 has
only one getter that returns a DBusValue.

In order to make the migration from GSettings 0.1 to 0.2 easier, hide
GSettings instances from the models and use nullable setting values to
eliminate the assumption that setting values are immediately available.
@jpnurmi jpnurmi mentioned this issue Dec 12, 2021
Merged
jpnurmi added a commit to jpnurmi/settings that referenced this issue Dec 12, 2021
@jpnurmi
Prepare settings listeners
8d1d880 
With gsettings.dart 0.2 (ubuntu-flutter-community#183) we can have change notifications. This
commit sets up the infrastructure for that, offloading noise from the
actual migration step that follows later when the blocker issues in
gsettings.dart have been resolved.
jpnurmi added a commit to jpnurmi/settings that referenced this issue Dec 12, 2021
@jpnurmi
Prepare settings listeners
6f38151 
With gsettings.dart 0.2 (ubuntu-flutter-community#183) we can have change notifications. This
commit sets up the infrastructure for that, offloading noise from the
actual migration step that follows later when the blocker issues in
gsettings.dart have been resolved.
@jpnurmi jpnurmi mentioned this issue Dec 12, 2021
Merged
jpnurmi added a commit to jpnurmi/settings that referenced this issue Dec 12, 2021
@jpnurmi
WIP: Port to GSettings 0.2
cc46859 
Closes: ubuntu-flutter-community#183
jpnurmi added a commit to jpnurmi/settings that referenced this issue Dec 13, 2021
@jpnurmi
WIP: Port to GSettings 0.2
47e5fd6 
Closes: ubuntu-flutter-community#183
jpnurmi added a commit to jpnurmi/settings that referenced this issue Dec 13, 2021
@jpnurmi
Migrate to GSettings 0.2
0afba4b 
Closes: ubuntu-flutter-community#183
@jpnurmi jpnurmi mentioned this issue Dec 13, 2021
Merged
Feichtmeier pushed a commit that referenced this issue Dec 13, 2021
@jpnurmi
Migrate to GSettings 0.2 (#191)
229e0bf 
Closes: #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpnurmi jpnurmi

Labels
feature / enhancement Needs implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to GSettings 0.2 jpnurmi/settings
2 participants
@jpnurmi @Feichtmeier