fix: TestShell timeouts #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been a while that GoWSL CI has been shown issues with TestShell. After some investigation I figured that first boot of the images used for testing is taking longer than what the test cases expect. Thus the timeout. From GoWSL's point-of-view it'd be better to use lighter images, without systemd for example. But since GoWSL's main use case is with Ubuntu, let's keep the images as is and just give the tests more time to run.
ashuntu
reviewed
Dec 5, 2024
ashuntu
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while that GoWSL CI has been shown issues with TestShell.
After some investigation I figured that first boot of the images used for testing is taking longer than what the test cases expect. Thus the timeout.
From GoWSL's point-of-view it'd be better to use lighter images, without systemd for example. But since GoWSL's main use case is with Ubuntu, let's keep the images as is and just give the tests more time to run.