Specify accent colors as MaterialColor constants

[jpnurmi]

Move the material color generation logic out to a separate helper tool
to be able to specify the accent colors as MaterialColor constants and
to get rid of the extra "fooMaterialColor" variables that were exposed
by the library.

[Feichtmeier]

Thank you this is much cooler!

[jpnurmi]

I was kind of testing the waters here to see the reaction. 😄 I'd love to try to make use of even more compile-time constants if possible. Compile-time constants not only provide better performance but can be used as default arguments too, for example. Non-constants have an unfortunate snowball effect that any code referencing them cannot be constants either.

[jpnurmi]

@Feichtmeier Are any other colors, such as the flavor colors, using similar logic or are the values chosen by hand?

[Feichtmeier]

@jpnurmi the flavor versions (if used at all) are just for the sake of being a complete ubuntu theme. They could be created in the same way ofc if you prefer! It is kind of a mish mash currently

Edit: ehhh sorry for the weird answer. The flavor colors are generated colors by some online tool I used (forgotten which one)
https://github.com/ubuntu/yaru.dart/blob/main/lib/src/colors/flavor_colors.dart
I mean, if your new tooling is reliant enough why not get rid of the flavor colors file ? :) Those material colors are a very cool idea for safe themes, but are a bit annoying to use because you need to create all shades. With your tooling it is a lot less painful

[jpnurmi]

The colors generated by https://material.io/inline-tools/color/ look a bit different. It has something more sophisticated under the hood. What do you think about these?

yaru.dart	material.io

[jpnurmi]

Oh, and it dynamically calculates the shade of the primary value too - not assumed 500. For orange and bark, it's 600, whereas olive is 800.

[Feichtmeier]

The colors generated by https://material.io/inline-tools/color/ look a bit different. It has something more sophisticated under the hood. What do you think about these?

yaru.dart	material.io

If this wouldn't change the shade500 colours and the contrast improves overall sounds good

[jpnurmi]

If this wouldn't change the shade500 colours and the contrast improves overall sounds good

With these colors, the primary shade is not always 500. It depends on the brightness of the primary value.

[Feichtmeier]

If this wouldn't change the shade500 colours and the contrast improves overall sounds good

With these colors, the primary shade is not always 500. It depends on the brightness of the primary value.

Ah! Okay sorry. Yes I meant if the primary colour doesn't change

[jpnurmi]

Ok, I'll take a closer look at the color tool algorithm.