Clear execstack, necessary for armhf builds, triggers review warning #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhenstridge
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Context from discussions elsewhere: the libde265 library is marked as having an executable stack on armhf. This is probably due to the ARM assembly code in the library. There seems to have been an attempt to mark the code safe here, but for whatever reason it hasn't taken:
https://github.com/strukturag/libde265/blob/master/libde265/arm/asm.S#L62
On the x86 side is using SSE intrinsics in C code rather than assembly, so that doesn't really offer any clues.
Manually marking the library safe seems like a reasonable way of dealing with the automated review failure. Worst case is it causes apps using the library to segfault on armhf if it indeed tries to execute code off the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.