Add missing dependency and tool for checking in Gnome-42 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a missing dependency in DEBS part: webp-pixbuf-loader. This patch adds it and also adds a check to ensure that any push fulfills the dependencies, ensuring that DEBS is ran after all the previous parts.
We must use a different way to ensure that all the dependencies are correct, because the python YAML module doesn't guarantee that the order is preserved, so, since the parts could be returned in a different order, we can't stop when we find "debs".
sergio-costas
requested review from
seb128
and removed request for
kenvandine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing dependency in DEBS part: webp-pixbuf-loader. This patch adds it and also adds a check to ensure that any push fulfills the dependencies, ensuring that DEBS is ran after all the previous parts.