Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtk4 symlink to upstream #2902

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Gtk4 symlink to upstream #2902

merged 3 commits into from
Jun 12, 2021

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Jun 12, 2021

  • Move all tweaks to _tweaks:
    • Green levelbar ;
    • Inverted headerbar (moved to _inverted-headerbar) ;
    • windowbuttons size and orange close button.
  • Symlink these files and folder to upstream ones:
    • _colors-public
    • _common
    • _drawing
    • _widgets
    • /widgets

Now all Yaru tweaks must be located inside _tweaks or _inverted-headerbar.

Jupi007 added 3 commits June 12, 2021 12:44
- Green levelbar
- Inverted headerbar
- windowbuttons size and orange close button
Symlink _colors-public _common _drawing _widgets and /widgets
@Feichtmeier
Copy link
Member

Feichtmeier commented Jun 12, 2021

I generally think this is a very good idea, since we have become fans of the upstream theme, and only change it to have our colors.
However, let @clobrano double check this, since I remember him saying symlinks can cause problems with meson or something :) I have forgotten what he said

Edit: I check if the theme works! 🥂

@Feichtmeier Feichtmeier requested a review from clobrano June 12, 2021 11:19
@clobrano
Copy link
Member

I remember him saying symlinks can cause problems with meson or something :) I have forgotten what he said

Just that currently meson copy the entire file when it finds a symlink, while in the future it will copy the symlink. So for now, all our symlinking magic works fine, but in the future we might need to rework it

(I'm actually writing this from fedora 34, so I think we can agree we've become upstream fans XD)

@Jupi007
Copy link
Member Author

Jupi007 commented Jun 12, 2021

Just that currently meson copy the entire file when it finds a symlink, while in the future it will copy the symlink. So for now, all our symlinking magic works fine, but in the future we might need to rework it

(I'm actually writing this from fedora 34, so I think we can agree we've become upstream fans XD)

Okay, thanks @clobrano
Let's merge this so.

@Jupi007 Jupi007 merged commit 37ff4a0 into master Jun 12, 2021
@Jupi007 Jupi007 deleted the Gtk4_symlink_to_upstream branch June 12, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants