Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement question adding interface #816

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

octoscorp
Copy link
Contributor

@octoscorp octoscorp commented Oct 20, 2023

The main changes are to preview.js, add_question.html, views.py, forms.py, and models.py (the latter three being under codewof/programming).

Other changes are generally small and self-explanatory, typically extending a module to better support the ways the new interface is different.

📑 Description

This adds a page for submitting questions. Currently, submitted questions are made into files and stored in a separate folder awaiting review. It also introduces randomisation models to the storage, however I have not had time to make use of them.

✅ Checks

  • I agree to the UCCSER Code of Conduct.
  • I have read the UCCSER Contributing Guide.
  • My pull request adheres to the code style for UCCSER.
  • I have updated the documentation (if required).

ℹ Additional Information

This will likely need to be reviewed with some acceptance testing due to its size.
See below image demonstrating how to reach the new interface.
image

This adds a page for submitting questions. Currently, submitted questions
are made into files and stored in a separate folder awaiting review.

The main changes are to preview.js, add_question.html, views.py, forms.py,
and models.py (the latter three being under codewof/programming).

Other changes are generally small and self-explanatory, typically extending
a module to better support the ways the new interface is different.
Update to previous commit to comply with style requirements
Configured style checker to ignore the same issues with submitted questions
as existing questions.

Additionally added a whitespace check to the review process, as the style
checker should ignore this on submitted files (due to the complexity that
checking this as part of saving the file would involve).
@octoscorp octoscorp marked this pull request as ready for review October 23, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant