Recreate Data Bias interactive #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eAlasdair
suggested changes
Nov 4, 2019
csfieldguide/static/interactives/bias-in-big-data/js/bias-in-big-data.js
Outdated
Show resolved
Hide resolved
csfieldguide/static/interactives/bias-in-big-data/js/bias-in-big-data.js
Outdated
Show resolved
Hide resolved
csfieldguide/static/interactives/bias-in-big-data/js/bias-in-big-data.js
Outdated
Show resolved
Hide resolved
csfieldguide/static/interactives/bias-in-big-data/js/bias-in-big-data.js
Outdated
Show resolved
Hide resolved
eAlasdair
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1182
Changes
Added features
Below are some features I added/altered that were not in the original interactive:
Notes
I'm not sure what should happen in the case that a user does find all of the circles (it is simple to inspect the page and find all of the circle divs to click). I feel if a user does this they are purposely going out of their way to miss the point of the interactive anyway.
It is theoretically possible that all circles on load of the interactive are all the same colour, however the probability of this is very very small. I did not come across this once while building and testing the interactive.
It is theoretically possible that all of the 'hidden' circles may partly overlap other circles, revealing their position. However I did not encounter this at all while building and testing the interactive (some overlapped but never all).
This interactive is for the chapter 'Big Data' that doesn't exist yet.