Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenJPEG writes to stderr #246

Closed
gcode-importer opened this issue Oct 8, 2013 · 9 comments
Closed

OpenJPEG writes to stderr #246

gcode-importer opened this issue Oct 8, 2013 · 9 comments
Assignees
Milestone

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 246

OpenJPEG has a nice system for people that don't want messages being logged to stdout/stderr.
Unfortunatly this system wasn't used yet everywhere.

Attached patch replaces printf by opj_event_msg where possible (and removes some logs
completely where it doesn't seem to make sense).

Patch was created using diff on OpenJPEG 2.0.0

Reported by brta.enfocus on 2013-10-08 12:39:31


- _Attachment: [remove remaining printf](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-246/comment-0/remove remaining printf)_
@gcode-importer
Copy link
Author

Would it be possible for you to generate a unified diff (diff -ru) ? Your patch does
not apply for me over here:

$ patch --verbose -p1 --dry-run < /tmp/test.patch 
Hmm...patch unexpectedly ends in middle of line
  I can't seem to find a patch in there anywhere.
patch: **** Only garbage was found in the patch input.

Reported by malaterre on 2014-02-24 08:39:13

@gcode-importer
Copy link
Author

see issue 184 for history

Reported by malaterre on 2014-02-25 15:46:58

  • Labels added: Milestone-Release2.1

@gcode-importer
Copy link
Author

Reported by malaterre on 2014-02-25 16:26:55

  • Labels added: Priority-Low
  • Labels removed: Priority-Medium

@gcode-importer
Copy link
Author

marking as wontfix until OP update status. thanks.

Reported by malaterre on 2014-03-03 11:53:58

  • Status changed: WontFix

@gcode-importer
Copy link
Author

Issue 184 has been merged into this issue.

Reported by malaterre on 2014-03-07 15:14:22

@gcode-importer
Copy link
Author

New patches created with commands
diff -ru Patched/src/lib/openjp2/image.c Original/src/lib/openjp2/image.c > Issue246-Patch2a.txt
diff -ru Patched/src/lib/openjp2/j2k.c Original/src/lib/openjp2/j2k.c > Issue247-Patch2b.txt
diff -ru Patched/src/lib/openjp2/openjpeg.c Original/src/lib/openjp2/openjpeg.c > Issue247-Patch2c.txt
diff -ru Patched/src/lib/openjp2/phix_manager.c Original/src/lib/openjp2/phix_manager.c
> Issue247-Patch2d
diff -ru Patched/src/lib/openjp2/ppix_manager.c Original/src/lib/openjp2/ppix_manager.c
> Issue247-Patch2e
diff -ru Patched/src/lib/openjp2/t2.c Original/src/lib/openjp2/t2.c > Issue247-Patch2f.txt
diff -ru Patched/src/lib/openjp2/t2.h Original/src/lib/openjp2/t2.h > Issue247-Patch2g.txt
diff -ru Patched/src/lib/openjp2/tcd.c Original/src/lib/openjp2/tcd.c > Issue247-Patch2h.txt
diff -ru Patched/src/lib/openjp2/tcd.h Original/src/lib/openjp2/tcd.h > Issue247-Patch2i.txt
diff -ru Patched/src/lib/openjp2/tgt.c Original/src/lib/openjp2/tgt.c > Issue247-Patch2j.txt
diff -ru Patched/src/lib/openjp2/tgt.h Original/src/lib/openjp2/tgt.h > Issue247-Patch2k.txt

Reported by brta.enfocus on 2014-07-07 10:10:40


- _Attachment: [Patches.zip](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-246/comment-6/Patches.zip)_

@gcode-importer
Copy link
Author

Reported by detonin on 2014-07-08 11:43:49

  • Status changed: Accepted

@mayeut
Copy link
Collaborator

mayeut commented Sep 4, 2015

@detonin, @malaterre,

There should't be any printf in stdout/stderr except in some j2k_dump_image* functions with a specific flag. If that's ok, issue can be closed.

@detonin
Copy link
Contributor

detonin commented Jan 25, 2016

Thanks. Closing then.

@detonin detonin closed this as completed Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants