Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better -ffast-math handling #554

Closed
wants to merge 1 commit into from
Closed

better -ffast-math handling #554

wants to merge 1 commit into from

Conversation

rdieter
Copy link
Contributor

@rdieter rdieter commented Jul 30, 2015

@mayeut
Copy link
Collaborator

mayeut commented Sep 4, 2015

@rdieter,

Could you update your PR to include the same guards as in commit c5dd603 please ?

mayeut added a commit that referenced this pull request Oct 15, 2015
@mayeut mayeut closed this Oct 15, 2015
@malaterre
Copy link
Collaborator

I do not believe we handle this in openjpeg

@mayeut
Copy link
Collaborator

mayeut commented Oct 15, 2015

We do on master and now on branch openjpeg-1.5 after commit 650df81

@malaterre
Copy link
Collaborator

I believe that openjpeg lossless mode currenly only works with -fexcess-precision=standard

@mayeut
Copy link
Collaborator

mayeut commented Oct 15, 2015

Lossless tests are okay without -fexcess-precision=standard since #591 and #571 were fixed. Am I missing something ?

@malaterre
Copy link
Collaborator

That's precisely my point. OpenJPEG lossless code path was actually lossy until a couple of weeks back (project is > 10 yrs old!). So I am suggesting to be a little bit modest and do not pretend we handle those advanced options for now. If distro packager wants to use this flags then it is their responsabilities, that's fine.

@mayeut
Copy link
Collaborator

mayeut commented Oct 15, 2015

I understand your point. However this is another issue than the one taken care of here which used to mess with floating point configuration for people linking with openjpeg.

@malaterre
Copy link
Collaborator

point taken. sorry for the noise.

@rdieter rdieter deleted the openjpeg-1.5 branch October 15, 2015 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants