-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode Sub-region #694
Decode Sub-region #694
Conversation
1. zero copy reads for buffer/memory mapped stream interface 2. no code block allocation
the user should NOT free image data on their own; they must call opj_image_destroy.
Strange, all builds pass (ignore ABI test) except gcc 64 bit release, where a lot of tests fail. |
@boxerab, could it be related to this warning: |
@mayeut nice catch - I left some debug code in one of my methods. Thanks. |
Well, just 8 broken tests to fix, and they are all related to a single image. Question: do we have any tests in the suite that test the |
There are tests using the |
@mayeut great, thanks! |
2. fix warnings, remove spurious white space, update license
} | ||
getchar(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boxerab Wouldn't that be the source of the stalled tests under travis ?
@mayeut once again, nice catch! I checked in some debug code again. |
I tested decoding of a 1000x1000 region from a large 22000x29000 image, tiled with 1024x1024 tiles. This branch took 600 ms, while the omnibus branch took around 1100 ms, on my system. |
…tart of the mqc buffer
Building on the omnibus branch, this branch adds fast sub-tile decode.
If a decode region is specified using the
-d
parameter, all code blocks that do not contributeto this region will be ignored, boosting decode speed considerably.
This is useful for decoding a sub region inside of a large single tile image.
Fixes #693 and #676