Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 640: Add core:informalType and link as parent of type-describing properties #641

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Issue 640: Add core:informalType and link as parent of type-describing properties #641

merged 1 commit into from
Dec 19, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Oct 28, 2024 •
edited
Loading

This Pull Request resolves all requirements of Issue #640 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (60fa32d)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (a21244e)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone Oct 28, 2024
@ajnelson-nist ajnelson-nist linked an issue Oct 28, 2024 that may be closed by this pull request
UCO should clarify role of informal type string fields vs. implemented classes #640
Open
16 tasks
@ajnelson-nist ajnelson-nist changed the title Add core:informalType and link as parent of type-describing properties Issue 640: Add core:informalType and link as parent of type-describing properties Oct 28, 2024
This was referenced Oct 28, 2024
Open
Draft
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review December 11, 2024 22:50
@ajnelson-nist ajnelson-nist requested a review from a team December 11, 2024 22:50
plbt5
plbt5 reviewed Dec 19, 2024
View reviewed changes
ontology/uco/observable/observable.ttl
@@ -4036,6 +4036,7 @@ observable:MSISDN

observable:MSISDNType
a owl:DatatypeProperty ;
rdfs:subPropertyOf core:informalType ;
rdfs:label "MSISDNType"@en ;
rdfs:comment "???."@en ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment without explanation is not useful. This should be addressed as a bug.

plbt5
plbt5 reviewed Dec 19, 2024
View reviewed changes
ontology/uco/observable/observable.ttl
@@ -10182,6 +10191,7 @@ observable:contentRecoveredStatus

observable:contentType
a owl:DatatypeProperty ;
rdfs:subPropertyOf core:informalType ;
rdfs:label "contentType"@en ;
rdfs:range xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This concept is defined without a comment describing what the type means.

plbt5
plbt5 reviewed Dec 19, 2024
View reviewed changes
ontology/uco/observable/observable.ttl
@@ -10335,6 +10345,7 @@ observable:dataPayloadReferenceURL

observable:dataType
a owl:DatatypeProperty ;
rdfs:subPropertyOf core:informalType ;
rdfs:label "dataType"@en ;
rdfs:range xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This concept is defined without a comment describing what the type means.

plbt5
plbt5 reviewed Dec 19, 2024
View reviewed changes
ontology/uco/observable/observable.ttl
@@ -10374,6 +10385,7 @@ observable:destinationPort

observable:deviceType
a owl:DatatypeProperty ;
rdfs:subPropertyOf core:informalType ;
rdfs:label "deviceType"@en ;
rdfs:range xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This concept is defined without a comment describing what the type means.

plbt5
plbt5 reviewed Dec 19, 2024
View reviewed changes
ontology/uco/observable/observable.ttl
@@ -12244,6 +12269,7 @@ observable:pdfModDate

observable:peType
a owl:DatatypeProperty ;
rdfs:subPropertyOf core:informalType ;
rdfs:label "peType"@en ;
rdfs:comment "Specifies the type of the PE binary."@en ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of abbreviations in a description should be discouraged.

plbt5
plbt5 reviewed Dec 19, 2024
View reviewed changes
ontology/uco/observable/observable.ttl
@@ -12854,6 +12882,7 @@ observable:serviceStatus

observable:serviceType
a owl:DatatypeProperty ;
rdfs:subPropertyOf core:informalType ;
rdfs:label "serviceType"@en ;
rdfs:range xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This concept is defined without a comment describing what the type means.

plbt5
plbt5 reviewed Dec 19, 2024
View reviewed changes
ontology/uco/observable/observable.ttl
@@ -13128,6 +13157,7 @@ observable:startTime

observable:startType
a owl:DatatypeProperty ;
rdfs:subPropertyOf core:informalType ;
rdfs:label "startType"@en ;
rdfs:range xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This concept is defined without a comment describing what the type means.

@ajnelson-nist
Copy link
Contributor Author

@plbt5 - I also saw those comment-string issues. They pre-exist this proposal.

plbt5
plbt5 reviewed Dec 19, 2024
View reviewed changes
ontology/uco/tool/tool.ttl
@@ -453,6 +453,7 @@ tool:swid

tool:toolType
a owl:DatatypeProperty ;
rdfs:subPropertyOf core:informalType ;
rdfs:label "toolType"@en ;
rdfs:comment "The type of tool."@en ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of description does not add to the comprehension of its meaning.

@plbt5 plbt5 merged commit 0405eac into develop Dec 19, 2024
1 check passed
@plbt5 plbt5 deleted the Feature-Issue-640 branch December 19, 2024 17:14
@plbt5
Copy link
Contributor

plbt5 commented Dec 19, 2024

The above comments should be resolved with a bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.4.0
Development

Successfully merging this pull request may close these issues.

UCO should clarify role of informal type string fields vs. implemented classes
2 participants
@ajnelson-nist @plbt5