Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform demo for riscv-mini , rocket16 and VCD header comparison (module and signal) #9

Merged
merged 11 commits into from
Apr 26, 2023

Conversation

MSPDUTTA
Copy link
Contributor

@MSPDUTTA MSPDUTTA commented Apr 5, 2023

No description provided.

@sbeamer
Copy link
Contributor

sbeamer commented Apr 8, 2023

Thank you for making this! Can you revise the following:

  1. Refactor the pull request into two pull requests? One for waveform-demo and one for waveform-test
  2. Soft linkTestHarness.DefaultConfig.1609.fir instead of copying it.
  3. Do not include libfesvr.so (a binary compiled for the host platform). I doubt it is needed in that exact location, and can probably change the paths in the Makefile to use the appropriate fesvr components from rocket16. If you do need it in that location, please use a soft link.

@MSPDUTTA
Copy link
Contributor Author

I have sent a request only for the waveform-demo with all these suggested updates.

@sbeamer
Copy link
Contributor

sbeamer commented Apr 13, 2023

I did a clean pull and after some modification, go it to run!

Please fix the following so others can just do a clean pull:

  1. For waveform-demo/rocket16, please fix the Makefile and such with regards to libfesvr.so. The easiest might be too soft link the riscv directory from rocket16.
  2. Bump the essent submodule pointer to include the VCD/FST commits.
  3. Softlink Tile.fir for riscv-mini.

@MSPDUTTA
Copy link
Contributor Author

I have updated with these modifications!

@sbeamer sbeamer merged commit 3805209 into ucsc-vama:master Apr 26, 2023
@sbeamer
Copy link
Contributor

sbeamer commented Apr 26, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants