Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligned images breaking out of content region #257

Closed
knice opened this issue Aug 16, 2023 · 1 comment · Fixed by #274
Closed

Aligned images breaking out of content region #257

knice opened this issue Aug 16, 2023 · 1 comment · Fixed by #274
Assignees
@Herm71
Labels
bug Something isn't working

Comments

@knice
Copy link
Member

knice commented Aug 16, 2023

We need to figure this one out. I think Rich Tabor has a blog post we should read to resolve this.

screenshot-2023-08-16-160909
@knice knice added the bug Something isn't working label Aug 16, 2023
@Herm71 Herm71 self-assigned this Oct 12, 2023
@Herm71
Copy link
Member

Herm71 commented Oct 12, 2023

A solution for this issue is discussed in the WordPress/gutenberg repo in Issue #37504 .

adding margin-left: calc((100% - var(--wp--style--global--content-size)) / 2) !important; to body .is-layout-constrained > .alignleft and body .is-layout-constrained > .alignright fixes the issue.

Herm71 added a commit that referenced this issue Oct 12, 2023
@Herm71
fix: 🐛 Correct issue of images breaking out of content area #257
9d1cbac
@Herm71 Herm71 mentioned this issue Oct 12, 2023
Merged
3 tasks
knice pushed a commit that referenced this issue Oct 26, 2023
@Herm71
fix: 🐛 Fixes #257, images that are aligned left or right break out of…
c47264f 
… their binding box (#274)

* fix: 🐛 Correct issue of images breaking out of content area #257
* refactor: 🎨 Move float fix CSS from `images.css` to `_alignments.scss` for global use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Herm71 Herm71

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Correct issue of images breaking out of content area ucsc/ucsc-2022
2 participants
@knice @Herm71