Map putchar('{char}') calls to printf '{char}` #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves a few seconds on dash, and makes the code easier to read. It compromises slightly from our principle of generating "regular" code without any special cases, but the original code looked bad and was harder to read so I think it's worth it.
laurenthuberdeau
commented
Jan 7, 2025
| @@ -84,15 +84,15 @@ _encode() { | |||
| printf \\$(((_$((_codes + (b1 >> 2))))/64))$(((_$((_codes + (b1 >> 2))))/8%8))$(((_$((_codes + (b1 >> 2))))%8)) | |||
| if [ $b2 -lt 0 ] ; then | |||
| printf \\$(((_$((_codes + (63 & (b1 << 4)))))/64))$(((_$((_codes + (63 & (b1 << 4)))))/8%8))$(((_$((_codes + (63 & (b1 << 4)))))%8)) | |||
| printf \\$(((__EQ__)/64))$(((__EQ__)/8%8))$(((__EQ__)%8)) | |||
| printf \\$(((__EQ__)/64))$(((__EQ__)/8%8))$(((__EQ__)%8)) | |||
| printf "=" | |||
There was a problem hiding this comment.
Much shorter and easier to read!
laurenthuberdeau
deleted the
laurent/optimize-putchar-with-char-literal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves a few seconds on dash, and makes the code easier to read. It compromises slightly from our principle of generating "regular" code without any special cases, but the original code looked bad and was harder to read so I think it's worth it.