Better ux #2
Open
Better ux #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… links to the membership overview view and more finely tuning access control
…s exist. Additional cleanup as well.
… exist, an access control handlers for adding membership and does some general cleanup
…eters were being overwritten.
…es for the group to exclude existing members from the available user entities.
…an count loaded membership entities.
…'s not typically triggered.
…tities to check for a user's existing membership.
This reverts commit a430a74.
…be defined in routing.yml fix the test
DiDebru
force-pushed
the
better_ux
branch
5 times, most recently
from
364255a to
b6fad8c
Compare
webflo
reviewed
Nov 26, 2018
| @@ -242,7 +284,7 @@ function og_entity_bundle_field_info(EntityTypeInterface $entity_type, $bundle, | |||
|
|
|||
| $fields = []; | |||
| $fields['og_group'] = BaseFieldDefinition::create('og_group') | |||
| ->setLabel(t('OG Group')) | |||
| ->setLabel('OG Group') | |||
There was a problem hiding this comment.
This change is unrelated, please revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.