Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust server global active connection counter to consider multiplexing #890

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

0xb4lamx
Copy link
Contributor

This PR updates the server getConnectionCount() to accurately handle multiplexed connections by considering unique socketIds. The previous implementation could overcount connections when multiple documents shared the same WebSocket connection.

@0xb4lamx
Copy link
Contributor Author

up! if someone could have a look here 👀

@janthurau
Copy link
Collaborator

janthurau commented Jan 17, 2025

@0xb4lamx thanks! I'm currently on holiday, sorry for the long wait. I've approved the pipeline but two tests seem to need adjustments, as we're asserting the connection count there. I agree the connection count should count per real connection (i.e. not count multiplexing connections n times), so happy to merge once fixed :-)

@0xb4lamx
Copy link
Contributor Author

@0xb4lamx thanks! I'm currently on holiday, sorry for the long wait. I've approved the pipeline but two tests seem to need adjustments, as we're asserting the connection count there. I agree the connection count should count per real connection (i.e. not count multiplexing connections n times), so happy to merge once fixed :-)

Thanks for your time! should be fixed in f691c1b 👀
image

@janthurau janthurau merged commit 4defd26 into ueberdosis:main Jan 19, 2025
3 checks passed
@janthurau
Copy link
Collaborator

Thank you! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants