Merge pull request #5745 from ueberdosis/update-editable-on-re-render

fix(react): preserve editable option across renders
ueberdosis · Oct 21, 2024 · 4cb6f98 · 4cb6f98
2 parents ffb51d3 + 304eedb
commit 4cb6f98
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/loud-maps-work.md b/.changeset/loud-maps-work.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/react": patch
+---
+
+preserve editable option across re-renders #5547
diff --git a/packages/react/src/useEditor.ts b/packages/react/src/useEditor.ts
@@ -199,7 +199,10 @@ class EditorInstanceManager {
       if (this.editor && !this.editor.isDestroyed && deps.length === 0) {
         // if the editor does exist & deps are empty, we don't need to re-initialize the editor
         // we can fast-path to update the editor options on the existing instance
-        this.editor.setOptions(this.options.current)
+        this.editor.setOptions({
+          ...this.options.current,
+          editable: this.editor.isEditable,
+        })
       } else {
         // When the editor:
         // - does not yet exist