fix: fix a bug for empty node selection where the bubble menu should …

…not be visible, fix #1023
ueberdosis · Apr 21, 2021 · 8ed220a · 8ed220a
1 parent d731b1f
commit 8ed220a
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts
@@ -88,9 +88,17 @@ export class BubbleMenuView {
       return
     }
 
-    const { from, to, empty } = selection
-
-    if (empty) {
+    const {
+      from,
+      to,
+      empty,
+      $anchor,
+    } = selection
+
+    // Sometime check for `empty` is not enough.
+    // Doubleclick an empty paragraph returns a node size of 2.
+    // So we check also for an empty text size.
+    if (empty || !$anchor.parent.textContent) {
       this.hide()
 
       return