fix(task-item): fix updating checked status (#5953)

* fix(task-item): fix updating checked status * fix: add some more updates --------- Co-authored-by: Nick the Sick <[email protected]>
ueberdosis · Dec 30, 2024 · d1b7dd2 · d1b7dd2
1 parent 4530606
commit d1b7dd2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/.changeset/orange-cows-pull.md b/.changeset/orange-cows-pull.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/extension-task-item": patch
+---
+
+Resolves an issue with the checkbox, where sometimes the check would not be properly updated
diff --git a/packages/extension-task-item/src/task-item.ts b/packages/extension-task-item/src/task-item.ts
@@ -183,9 +183,7 @@ export const TaskItem = Node.create<TaskItemOptions>({
       })
 
       listItem.dataset.checked = node.attrs.checked
-      if (node.attrs.checked) {
-        checkbox.setAttribute('checked', 'checked')
-      }
+      checkbox.checked = node.attrs.checked
 
       checkboxWrapper.append(checkbox, checkboxStyler)
       listItem.append(checkboxWrapper, content)
@@ -203,11 +201,7 @@ export const TaskItem = Node.create<TaskItemOptions>({
           }
 
           listItem.dataset.checked = updatedNode.attrs.checked
-          if (updatedNode.attrs.checked) {
-            checkbox.setAttribute('checked', 'checked')
-          } else {
-            checkbox.removeAttribute('checked')
-          }
+          checkbox.checked = updatedNode.attrs.checked
 
           return true
         },