Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating menu and code block #1503

Closed
multipliedtwice opened this issue Jun 23, 2021 · 1 comment · Fixed by #1714
Closed

Floating menu and code block #1503

multipliedtwice opened this issue Jun 23, 2021 · 1 comment · Fixed by #1714
Labels
Type: Feature The issue or pullrequest is a new feature

Comments

@multipliedtwice
Copy link

multipliedtwice commented Jun 23, 2021 •
edited
Loading

The problem I am facing
image

Lists don't have it:
image

The solution I would like

  1. Would it be good to hide the floating menu inside of code block or make it configurable?
  2. What would be the best way to make it more slack-like: enable code block by ``` without space entering and step out of code block by keyboard arrows? If the first added element was `code block` - not clear how to enter any text before it.
  3. Floating menu also ignores editor.commands.focus(); and doesn't appear.
  4. Paste from vscode and turning on code block from menu resulting in separated code block for every pasted line
@multipliedtwice multipliedtwice added Type: Feature The issue or pullrequest is a new feature v2 labels Jun 23, 2021
@multipliedtwice multipliedtwice changed the title Hide floating menu in empty codeblock and enable on ``` without space Hide floating menu in empty codeblock and enable ``` without space Jun 23, 2021
@multipliedtwice multipliedtwice changed the title Hide floating menu in empty codeblock and enable ``` without space Floating menu and code block Jun 23, 2021
@philippkuehn philippkuehn mentioned this issue Aug 11, 2021
Merged
philippkuehn added a commit that referenced this issue Aug 11, 2021
@philippkuehn
feat: add key option and shouldShow option to menus (fix #1480, fix #…
9ba61c1 
…1043, fix #1268, fix #1503)

* add key option to bubble menu

* ignore react for now

* add shouldShow option to bubble menu extension

* improve types

* remove BubbleMenuPluginKey

* add key and shouldShow option to floating menu extension

* fix: don’t show floating menu within code block

* docs: add new menu options
@multipliedtwice
Copy link
Author

@philippkuehn thank you! Amazing!

andrewlu0 pushed a commit to trybaseplate/tiptap that referenced this issue Oct 20, 2023
@philippkuehn
feat: add key option and shouldShow option to menus (fix ueberdosis#1480
4ab829f 
, fix ueberdosis#1043, fix ueberdosis#1268, fix ueberdosis#1503)

* add key option to bubble menu

* ignore react for now

* add shouldShow option to bubble menu extension

* improve types

* remove BubbleMenuPluginKey

* add key and shouldShow option to floating menu extension

* fix: don’t show floating menu within code block

* docs: add new menu options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature The issue or pullrequest is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Menu improvements ueberdosis/tiptap
1 participant
@multipliedtwice