Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Extension, always adding target="_blank" when instatiating editor. #3276

Closed
1 of 2 tasks
MichalKrakow opened this issue Oct 4, 2022 · 1 comment · Fixed by #3425
Closed
1 of 2 tasks

Link Extension, always adding target="_blank" when instatiating editor. #3276

MichalKrakow opened this issue Oct 4, 2022 · 1 comment · Fixed by #3425
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@MichalKrakow
Copy link

What’s the bug you are facing?

As stated in title, not sure why its happening, but with link extension enabled, when theres a link without target attribute its added there anyway with _blank value in it.

Which browser was this experienced in? Are any special extensions installed?

Chrome

How can we reproduce the bug on our side?

open editor with:

<p>
<a href="/jobs/new">jobs</a>
</p>

Interesting enough this is not passed on with value - just rendered inside editor content element.

Can you provide a CodeSandbox?

No response

What did you expect to happen?

It would be great to have some configuration allowing to discard this behaviour

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@MichalKrakow MichalKrakow added the Type: Bug The issue or pullrequest is related to a bug label Oct 4, 2022
@dargmuesli
Copy link
Contributor

Hey there, it seems that target and rel attributes are now set by default. To not set them, you must use null. This is currently not allowed by the typing, so I've submitted a PR to fix this.

bdbch pushed a commit that referenced this issue Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants