[Bug]: Collaboration cursor flickering #5492
Labels
Category: Open Source
The issue or pull reuqest is related to the open source packages of Tiptap.
Type: Bug
The issue or pullrequest is related to a bug
Comments
tehbelinda
added
Category: Open Source
nperez0111
added a commit
that referenced
this issue
Aug 15, 2024
5 tasks
nperez0111
added a commit
that referenced
this issue
Aug 15, 2024
…5496) The core of the change ended up being quite simple, because we can create the editor within the first render, we need to already schedule it's destruction. Scheduling a destruction, ensures that an instance that was created in that first render pass can be cleaned up. Waiting one more tick than before ensures that we don't accidentally destroy an editor instance that could actually be valid in the next render pass. In StrictMode, there will be two editor instances created, the first will be created & quickly destroyed in 2 ticks. In Normal React, there will only ever be 1 instance created and destroyed only on unmount.
|
Thank you for the reproducible example, it was indeed strict mode handling again. StrictMode has weird behaviors, luckily this was not in issue in production or in normal react rendering. StrictMode should be handled correct with |
|
thank you! appreciate the quick turnaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected Packages
extension-collaboration-cursor, react
Version(s)
2.6.0
Bug Description
When a user focuses on the editor in a way that makes the user's cursor visible, other users will see their cursor flickering rapidly. The behaviour is like that seen in #4482 (and potentially also #4993)
Browser Used
Chrome
Code Example URL
https://codesandbox.io/p/devbox/condescending-galileo-9djp46
(I forked the sandbox from #4482 but updated the packages to 2.6.0)
Expected Behavior
The cursor should be stable, not flickering
Additional Context (Optional)
Here is a video of it flickering:
https://github.com/user-attachments/assets/fd2ffb8c-243b-4337-9285-9f04067a736e
I tried turning off strict mode (inspired by what happened previously in #4482) and the flickering stopped
I noticed there were a bunch of editor lifecycle updates in the react package in 2.5.0+, so I reverted to 2.5.0 - confirmed the flickering still persisted. Then I tried 2.4.0, and the flickering stopped (see https://codesandbox.io/p/devbox/determined-hawking-ts6gfp).
Dependency Updates
The text was updated successfully, but these errors were encountered: