[Bug]: ESC closes mentions dropdown, but items will still be selected and actions still forwarded to the menu

[Nantris]

Affected Packages

extension-suggestion

Version(s)

2.7.2

Bug Description

After pressing ESC the menu is still active, just hidden, since this PR enabled hiding it with ESC: #5544

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

ESC truly closes the menu. Enter and arrow keys should affect the editor, not a hidden menu.

Additional Context (Optional)

No response

Dependency Updates

• Yes, I've updated all my dependencies.

[gethari]

If I understand correctly, after doing @ when user hit Esc we should ideally get rid of the inserted @ as well ? I guess that would solve this problem ?

[nperez0111]

If I understand correctly, after doing @ when user hit Esc we should ideally get rid of the inserted @ as well ? I guess that would solve this problem ?

No, we do need to let the user to type an @ character. I think it just needs to destroy the menu until the next actual character. If the user goes next to the @ again and there is only white space to the right of it, it should reopen the menu.

I would take a PR to fix this, but honestly it is just very annoying behavior to implement and get right

[gethari]

@nperez0111 , I am able to overcome this issue by making the below changes, let me know if I can create a PR for this

Diff

Video

2024-09-30.at.15.03.26.-.Bronze.Puma.mp4

[rfgamaral]

@gethari Not a maintainer, but so that you know, that is only a workaround for the Mention extension (one that doesn't really destroy the menu), it doesn't really fix the core issue. The core issue needs to be fixed in the Suggestion utility, most likely.

[gethari]

@rfgamaral yeah I understand, ideally the renderer?.onKeyDown?. should be stopped from executing that is based on the flags getting computed above