Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suggestion): dropdown can't be closed with Esc (#4380) #5544

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

rfgamaral
Copy link
Contributor

@rfgamaral rfgamaral commented Aug 23, 2024

Changes Overview

See discussion here: #4380 (comment)

Implementation Approach

Suggested by @nperez0111.

Testing Done

I checked that this works with the single room collaboration demo opened in different browsers, and manually tested all the small issues for which I recorded small videos in the commented linked above.

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 8a798e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/suggestion Patch
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 8a798e3
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66c85b6653d917000828fc6f
😎 Deploy Preview https://deploy-preview-5544--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111
Copy link
Contributor

Appreciate your verification @rfgamaral glad it worked (that never happens 😄 )

@nperez0111 nperez0111 merged commit daad533 into ueberdosis:develop Aug 23, 2024
14 checks passed
@rfgamaral rfgamaral deleted the ricardo/fix-4380 branch August 23, 2024 10:28
@nperez0111
Copy link
Contributor

Releasing v2.6.6 now

@nperez0111 nperez0111 mentioned this pull request Aug 27, 2024
5 tasks
@Nantris
Copy link
Contributor

Nantris commented Sep 18, 2024

I notice that this PR only hides the dropdown, but if the user presses Enter with it hidden, the suggestion will still submit. The currently exposed properties don't appear to be sufficient for end-developers to work around this themselves unless I'm overlooking something.

In the same vein, when the user continues typing and then presses enter this can also occur.

Demo page: https://tiptap.dev/docs/examples/advanced/mentions

@Nantris
Copy link
Contributor

Nantris commented Sep 24, 2024

Anyone have thoughts on how this could be addressed? Should I make a new issue for this?

@nperez0111
Copy link
Contributor

New issue would be preferred over tracking here. Overall this code is a mess to maintain & would require a refactor from first principles to actually be acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants