-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(suggestion): dropdown can't be closed with Esc
(#4380)
#5544
Conversation
🦋 Changeset detectedLatest commit: 8a798e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d21b573
to
8a798e3
Compare
Appreciate your verification @rfgamaral glad it worked (that never happens 😄 ) |
Releasing v2.6.6 now |
I notice that this PR only hides the dropdown, but if the user presses In the same vein, when the user continues typing and then presses enter this can also occur. Demo page: https://tiptap.dev/docs/examples/advanced/mentions |
Anyone have thoughts on how this could be addressed? Should I make a new issue for this? |
New issue would be preferred over tracking here. Overall this code is a mess to maintain & would require a refactor from first principles to actually be acceptable |
Changes Overview
See discussion here: #4380 (comment)
Implementation Approach
Suggested by @nperez0111.
Testing Done
I checked that this works with the single room collaboration demo opened in different browsers, and manually tested all the small issues for which I recorded small videos in the commented linked above.
Checklist