Fix: code-block-lowlight child extensions do not highlight code #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the extension name when initializing the LowlightPlugin. In this way, several extensions can make use of the same plugin
enriquecastl
changed the title
|
great! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes a bug in the Code Block Lowlight extension that doesn’t allow extending the extension further. When we extend
CodeBlockLowlight, the code in the child extension is not highlighted. We discovered that the root cause of this problem is a hard coded extension named provided to theLowlightPlugin. Passing the extension name fixes this problem.This PR also contains a failing test.