Floating menu - remove composition check #2137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some more debugging on #1994 and found out that the problem (floating menu does not hide when you type) happens when composition is true (https://firefox-source-docs.mozilla.org/editor/IMEHandlingGuide.html).
The common cases I found:
This PR simply removes check if composition is true. I use floating menu for both menu on empty line (as Tiptap example does) and menu attached at the end of the current line as you type. In both cases, I want update position/hide menu on typing any character, even if it is in composition mode.
I think we don't care for composition and
shouldShow()
should handle it.The question I have is Was check for composition added for any specific reason?
I don't have experience with composition so maybe I am missing something and the check is actually needed, in that case reject this PR please.
Fixes #1994