Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When using Tiptap, there's no way to mark a Node/Mark attribute as required. Tiptap sets
default: null
for every attribute, and there's no way to clear this if you want an attr to be required. This causes downstream issues - for example, ProseMirror'sjoinBackward
command may try to create a wrapping with a node that has a required attribute, without knowing how to fill it in. ProseMirror tries to guard against this using the NodeType's hasRequiredAttrs method, but when using Tiptap it will always returnfalse
.Solution: Add a new, optional,
isRequired
option on attrs. If an attr is set up with this property, and no default, then thedefault: null
will be deleted and then ProseMirror'shasRequiredAttrs
will return true.Alternatively, I also considered allowing users to pass
default: undefined
, but this seemed more explicit.Impact: Without this fix in @tiptap/core, I'm currently using an extension to hack this behavior. It's pretty hacky: