Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): isNodeSelection, isTextSelection not always false #3089

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix(core): isNodeSelection, isTextSelection not always false #3089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/core/src/helpers/isNodeSelection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { NodeSelection } from 'prosemirror-state'

import { isObject } from '../utilities/isObject'

export function isNodeSelection(value: unknown): value is NodeSelection {
return isObject(value) && value instanceof NodeSelection
return value instanceof NodeSelection
}
4 changes: 1 addition & 3 deletions packages/core/src/helpers/isTextSelection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { TextSelection } from 'prosemirror-state'

import { isObject } from '../utilities/isObject'

export function isTextSelection(value: unknown): value is TextSelection {
return isObject(value) && value instanceof TextSelection
return value instanceof TextSelection
}
7 changes: 0 additions & 7 deletions packages/core/src/utilities/isClass.ts
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions packages/core/src/utilities/isObject.ts
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions tests/cypress/integration/core/isClass.spec.ts
View file
Open in desktop

This file was deleted.