fix(extension/placeholder): Resolve placeholder performance issues #3361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3360
The issue seems to be caused by this line in
placeholder.ts
:tiptap/packages/extension-placeholder/src/placeholder.ts
Line 54 in 2b69f34
isEmpty
is NOT a simple operation, but uses JSON stringify on the entire document to verify emptiness compared to the default of the given node type.This wouldn't be too bad on it's own, but it's called for every descendent, causing noticeable performance issues if more than a few empty paragraphs exist on a large document (even on the Moby Dick large text example).
The issue was actually fixed with #2665 but was then reverted by 1024892 for an unknown reason
Credit to @BrianHung for the more efficient empty editor check