Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export createNodeFromContent and other missing helpers #3558

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

jacksleight
Copy link
Contributor

@jacksleight jacksleight commented Dec 17, 2022

I'd like to use the createNodeFromContent helper in a project, but it's not currently exported. While looking at this I found there are few others that also aren't exported, so this PR adds in all the missing ones.

If there's a reason any of these aren't exported I can remove them, but createNodeFromContent would be really useful!

@netlify
Copy link

netlify bot commented Dec 17, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit e1a1c70
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/639de0b39b4dc20008054e92
😎 Deploy Preview https://deploy-preview-3558--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Doerge
Copy link

Doerge commented Jan 3, 2023

I need to use createChainableState for a custom Keymap extension, so exporting everything that is not some sort of private API would be great for me.

@bdbch bdbch merged commit 26c3498 into ueberdosis:main Feb 18, 2023
@jacksleight jacksleight deleted the export-all-helpers branch February 18, 2023 22:49
aliasliao pushed a commit to aliasliao/tiptap that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants