feat: drag and drop across multi editors #4328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Another related pull request: #3429 |
bdbch
requested changes
Aug 18, 2023
|
@songispm is this ready to merge given the change which was requested was made? |
|
yes, I think it's worked. |
|
Great work! Is it straightforward to do this React? I see there’s currently only a Vue example. @bdbch if you are happy do you think this could get in to a release? |
|
Would like to use this feature! |
nperez0111
force-pushed
the
develop
branch
2 times, most recently
from
bcaef5c to
7e7ae19
Compare
|
Moved to #5893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Delete content when drop on another editor,
At the same time, it does not affect the normal drop event effect of the editor.
Work in nested nodes too.
Core change of code:
https://github.com/ueberdosis/tiptap/pull/4328/files#diff-6eddae5591c39b131ab5597e8ac574df71fafda96023c4573c45fd73ed066b9f
Related issues
#3133
Demo
https://deploy-preview-4328--tiptap-embed.netlify.app/preview/Experiments/MultipleEditors
or checkout this pull request
iShot_2023-08-14_00.48.28.mp4