-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make img.ProseMirror-separator
0px
#4646
Make img.ProseMirror-separator
0px
#4646
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Otherwise if there is an atom as the last thing on a line in chrome you can't select back from it
c939b4d
to
c2bff7e
Compare
Related: #2690 |
What's blocking this PR? This fixes several bugs for text selection |
bcaef5c
to
7e7ae19
Compare
🦋 Changeset detectedLatest commit: 552685a The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, I have tested this and believe it resolves several related bugs
Please describe your changes
Make
img.ProseMirror-separator
0px because otherwise if there is an atom as the last thing on a line in chrome you can't click and drag to select back from it.How have you tested your changes
Tested on the demo in Chrome
119.0.6045.159
on https://tiptap.dev/api/nodes/mention with a few tweaks:display: inline-block
instead ofinline
. Without this it's still broken even with this fix, and I thinkinline-block
still makes sense. Maybe the plugin should be updated to useinline-block
? You can see withinline
when you click at the end of the line the cursor actually ends up inside the mention instead of outside, which seems a bit strange.width
andheight
as0
.1px
image, it doesn't.Screen.Recording.2023-11-21.at.11.43.00.mp4
Also tested these changes in our real project and it seems to work.
And tested in the deploy preview here.
How can we verify your changes
See the steps above.
Checklist
Related issues
ProseMirror/prosemirror-view#162