Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make img.ProseMirror-separator 0px #4646

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

tjenkinson
Copy link
Contributor

@tjenkinson tjenkinson commented Nov 21, 2023

Please describe your changes

Make img.ProseMirror-separator 0px because otherwise if there is an atom as the last thing on a line in chrome you can't click and drag to select back from it.

How have you tested your changes

Tested on the demo in Chrome 119.0.6045.159 on https://tiptap.dev/api/nodes/mention with a few tweaks:

  1. Make the mention nodes display: inline-block instead of inline. Without this it's still broken even with this fix, and I think inline-block still makes sense. Maybe the plugin should be updated to use inline-block? You can see with inline when you click at the end of the line the cursor actually ends up inside the mention instead of outside, which seems a bit strange.
  2. Update the css for the img hack to have width and height as 0.
  3. Update the text to be a string and then a tag followed by nothing (which means you need to remove the empty space the plugin adds)
  4. Try and click and drag to select from the end. It should work. With the 1px image, it doesn't.
Screen.Recording.2023-11-21.at.11.43.00.mp4

Also tested these changes in our real project and it seems to work.

And tested in the deploy preview here.

How can we verify your changes

See the steps above.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

ProseMirror/prosemirror-view#162

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 552685a
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66bbc422438ee80008155d56
😎 Deploy Preview https://deploy-preview-4646--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Otherwise if there is an atom as the last thing on a line in chrome you can't select back from it
@tjenkinson tjenkinson marked this pull request as ready for review November 21, 2023 12:00
@tjenkinson tjenkinson force-pushed the image-separator-hack-0px branch from c939b4d to c2bff7e Compare November 21, 2023 12:00
@Billiam
Copy link
Contributor

Billiam commented Nov 21, 2023

Related: #2690

@Pruxis
Copy link
Contributor

Pruxis commented Jan 26, 2024

What's blocking this PR? This fixes several bugs for text selection

@nperez0111 nperez0111 force-pushed the develop branch 2 times, most recently from bcaef5c to 7e7ae19 Compare June 12, 2024 04:33
@bdbch bdbch deleted the branch ueberdosis:develop June 26, 2024 21:57
@bdbch bdbch closed this Jun 26, 2024
@bdbch bdbch reopened this Jun 27, 2024
Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 552685a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, I have tested this and believe it resolves several related bugs

@nperez0111 nperez0111 merged commit da76972 into ueberdosis:develop Aug 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants