Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add data attribute on ReactNodeView mounting div to assist styling #5539

Merged

Conversation

WilliamIPark
Copy link
Contributor

@WilliamIPark WilliamIPark commented Aug 22, 2024

Changes Overview

The goal of this PR is to make the react mounting element a bit more identifiable. This should aid the ability to select and style this element via CSS.

Implementation Approach

Added a data attribute to the element just after it is created, and is confirmed to exist.

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: 03ba553

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 03ba553
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66c766eb40f8fa0008decbb8
😎 Deploy Preview https://deploy-preview-5539--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WilliamIPark WilliamIPark marked this pull request as draft August 22, 2024 14:30
@WilliamIPark WilliamIPark marked this pull request as ready for review August 22, 2024 14:40
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate this

@nperez0111 nperez0111 merged commit fafb5ad into ueberdosis:develop Aug 23, 2024
14 checks passed
@nperez0111 nperez0111 mentioned this pull request Aug 27, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants