fix(react): Fix incorrect extensionAttributes value #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ddc31b The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nperez0111
reviewed
Sep 15, 2024
Comment on lines
307
to
309
| const extensionAttributes = this.editor.extensionManager.attributes.filter( | ||
| attribute => attribute.type === this.node.type.name, | ||
| ) |
There was a problem hiding this comment.
Sorry, what did you run into that warrants this change? It is not clear to me why it is needed? It feels like something that is better placed as a responsibility of getRenderedAttributes instead
There was a problem hiding this comment.
The "attrs" function would accept all extensions' acttributes, it wasn't what i expected, it only need accpet relative extensions' acttributes. Maybe there's a better way to write it that I don't know?
There was a problem hiding this comment.
Yep, you are right here. I just think it is better implemented in the function getRenderedAttributes instead.
There was a problem hiding this comment.
I normally would just apply my patch on top of the branch, but some reason it was disabled, so here is the patch I would apply to this PR
diff --git a/packages/core/src/helpers/getRenderedAttributes.ts b/packages/core/src/helpers/getRenderedAttributes.ts
index 5dd0855a2..fd85e699a 100644
--- a/packages/core/src/helpers/getRenderedAttributes.ts
+++ b/packages/core/src/helpers/getRenderedAttributes.ts
@@ -8,6 +8,9 @@ export function getRenderedAttributes(
extensionAttributes: ExtensionAttribute[],
): Record<string, any> {
return extensionAttributes
+ .filter(
+ attribute => attribute.type === nodeOrMark.type.name,
+ )
.filter(item => item.attribute.rendered)
.map(item => {
if (!item.attribute.renderHTML) {
diff --git a/packages/react/src/ReactNodeViewRenderer.tsx b/packages/react/src/ReactNodeViewRenderer.tsx
index 054b69130..4f16c0c8c 100644
--- a/packages/react/src/ReactNodeViewRenderer.tsx
+++ b/packages/react/src/ReactNodeViewRenderer.tsx
@@ -304,9 +304,7 @@ export class ReactNodeView<
let attrsObj: Record<string, string> = {}
if (typeof this.options.attrs === 'function') {
- const extensionAttributes = this.editor.extensionManager.attributes.filter(
- attribute => attribute.type === this.node.type.name,
- )
+ const extensionAttributes = this.editor.extensionManager.attributes
const HTMLAttributes = getRenderedAttributes(this.node, extensionAttributes)
attrsObj = this.options.attrs({ node: this.node, HTMLAttributes })
There was a problem hiding this comment.
That's great! But i am not sure if it will break the previous features?
nperez0111
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Prevent to call renderHTML function of all extensions.
Implementation Approach
Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues