feat: Surface Salesforce load/save errors (#31)

.prettierrc.yaml

@@ -1,6 +1,7 @@
 tabWidth: 4
 semi: false
 useTabs: true
+trailingComma: es5
 overrides:
   - files: "*.yaml"
     options:

apps/salesforce/bundle/bots/load/salesforce_load/bot.ts

@@ -255,22 +255,27 @@ export default function salesforce_load(bot: LoadBotApi) {
 		let errMessage = ""
 		let responseObj: Record<string, object>
 		if (typeof response.body === "string") {
-			//bot.log.info("response body is string")
 			try {
 				responseObj = JSON.parse(response.body as string)
 				if (responseObj.error) {
 					errMessage = responseObj.error as unknown as string
 				}
 				// eslint-disable-next-line no-empty
 			} catch (e) {}
-		} else {
-			errMessage = response.body as unknown as string
+		} else if (response.body && typeof response.body === "object") {
+			if (response.body.error) {
+				errMessage = response.body.error as string
+			} else {
+				bot.log.error(
+					"unexpected error response from salesforce",
+					response.body
+				)
+			}
 		}
 		if (errMessage) {
-			bot.log.error("error from salesforce", errMessage)
-			bot.addError(errMessage)
+			bot.addError("error making salesforce request: " + errMessage)
+			return
 		}
-
 		return
 	}
 	const soqlResponse = response.body as SoqlResponse

apps/salesforce/bundle/bots/save/salesforce_save/bot.ts

@@ -243,13 +243,19 @@ export default function salesforce_save(bot: SaveBotApi) {
 				}
 				// eslint-disable-next-line no-empty
 			} catch (e) {}
-		} else {
-			errMessage = response.body as unknown as string
+		} else if (response.body && typeof response.body === "object") {
+			if (response.body.error) {
+				errMessage = response.body.error as string
+			}
 		}
 		if (errMessage) {
-			bot.log.error("error from salesforce", errMessage)
+			bot.addError(
+				"error making salesforce request: " + errMessage,
+				"",
+				""
+			)
+			return
 		}
-		// bot.addError(errMessage)
 		return
 	}
 	const responseBody = response.body as CompositeResponse