Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(smartsheet): Ability to filter for specific sheet row #32

Merged
merged 4 commits into from
Nov 22, 2023
Merged

feat(smartsheet): Ability to filter for specific sheet row #32

merged 4 commits into from
Nov 22, 2023

Conversation

zachelrath
Copy link
Contributor

What does this PR do?

  1. (Smartsheet) Adds ability to filter for just one row
  2. Salesforce and Smartsheet: Adds initial unit tests for the Load bots with Jest

Testing

From base directory you can now run tests with npm test which should run the NX tests on all Projects

npm i
npm test

@zachelrath zachelrath requested a review from humandad November 21, 2023 18:03
@zachelrath zachelrath self-assigned this Nov 21, 2023
@zachelrath zachelrath enabled auto-merge (squash) November 21, 2023 18:03
@zachelrath zachelrath mentioned this pull request Nov 21, 2023
Closed
@zachelrath zachelrath force-pushed the smartsheet-row-ids-condition branch from d61197b to 8aa9551 Compare November 21, 2023 20:38
@zachelrath zachelrath force-pushed the smartsheet-row-ids-condition branch from 8aa9551 to e5396be Compare November 21, 2023 20:41
ghost
ghost approved these changes Nov 22, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work test worked locally for me and I tested the row filter and works.
The only thing that isn't working is deactivating a condition, but not sure if that is managed in the integration itself or Uesio side. We can open a separated PR for that.

@zachelrath zachelrath removed the request for review from humandad November 22, 2023 12:15
@zachelrath zachelrath disabled auto-merge November 22, 2023 12:16
@zachelrath zachelrath merged commit c56f2e5 into main Nov 22, 2023
1 check passed
@zachelrath zachelrath deleted the smartsheet-row-ids-condition branch November 22, 2023 12:16
@TCMMatthiasFankhauser TCMMatthiasFankhauser mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@zachelrath zachelrath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zachelrath