Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused module files #237

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

Remove unused module files, and an obsolete global_chgres script that used these module files.

Issue #235

Remove unused module files.

The ush/fv3gfs_chgres.sh script uses them.  But that
script runs the old chgres for initializing global runs.
It has since been replaced by the utility in ./util/gdas_init.

Issue ufs-community#235.
Merge branch 'develop' into feature/mod_cleanup

Issue ufs-community#235.
Copy link
Collaborator

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloned branch on Orion and ran build_all.sh. Built without issue. I notice that it is using v1.0.0-beta1 hpc-stack, very nice! I approve this cleanup, thanks George!

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 19942e0 into ufs-community:develop Dec 15, 2020
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the feature/mod_cleanup branch December 18, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants