refactor: eslint findings

ui5-community · Feb 6, 2025 · fcf2c7b · fcf2c7b
1 parent 7d3222b
commit fcf2c7b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/lib/wdi5-bridge.ts b/src/lib/wdi5-bridge.ts
@@ -440,6 +440,7 @@ export async function _addWdi5Commands(browserInstance: WebdriverIO.Browser) {
                                       // when object is undefined the previous function call failed
                                       try {
                                           return object[prop]
+                                          // eslint-disable-next-line @typescript-eslint/no-unused-vars
                                       } catch (error) {
                                           // different node versions return a different `error.message` so we use our own message
                                           if (logging) {
@@ -474,7 +475,7 @@ export async function _addWdi5Commands(browserInstance: WebdriverIO.Browser) {
                 // eslint-disable-next-line @typescript-eslint/no-empty-function
                 return new Proxy(function () {}, handler)
             }
-            // @ts-ignore
+            // @ts-expect-error as design-time is not aware of _asControl
             return makeFluent(browserInstance._asControl(ui5ControlSelector))
         }
     }

diff --git a/src/lib/wdi5-fe.ts b/src/lib/wdi5-fe.ts
@@ -64,7 +64,7 @@ export class WDI5FE {
         // yet only wave the wand when there's an iframe somewhere,
         // indicating BTP WorkZone territory
         await browserInstance.switchToParentFrame()
-        // @ts-ignore
+        // @ts-expect-error Element cast to iframe
         const iframe: Element = await browserInstance.findElement("css selector", "iframe")
         let shell
         if (!iframe.error) {
@@ -80,6 +80,7 @@ export class WDI5FE {
             // back to app
             try {
                 await browserInstance.switchToFrame(0)
+                // eslint-disable-next-line @typescript-eslint/no-unused-vars
             } catch (err) {
                 // This try-catch block is a fail-safe code to make sure the execution continues if browser fails to switch to app's frame.
                 // It has been observed that for Launchpad apps, the switchToFrame(0) is not required.