Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with dynamic insertion + removal #243

Merged
merged 5 commits into from
May 4, 2020
Merged

Fix issues with dynamic insertion + removal #243

merged 5 commits into from
May 4, 2020

Conversation

msaps
Copy link
Member

@msaps msaps commented May 4, 2020

Fixes a number of issues that were related to the dynamic insertion/deletion logic in PageboyViewController.

Specifically:

  • Fixes issue where inserting a page at the current index with doNothing PageUpdateBehavior would display the inserted view controller (Resolves Incorrect behaviour when calling insertPage at currentIndex #211)
  • Fix issue where deleting a page on an upper index could cause index corruption.
  • Fix issue where scroll interaction during updates could cause index corruption (touches are now forcibly cancelled and interaction disabled until updates have completed).

@msaps msaps force-pushed the feature/insert-fix branch from 0fff357 to 0847dae Compare May 4, 2020 07:21
@uias-bot
Copy link
Member

uias-bot commented May 4, 2020

1 Warning
⚠️ Looks like you changed some source files, should there have been some tests added?

Generated by 🚫 Danger

@msaps msaps merged commit 9553e46 into master May 4, 2020
@msaps msaps deleted the feature/insert-fix branch May 4, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behaviour when calling insertPage at currentIndex
2 participants
@msaps @uias-bot