Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set constraints after addSubview for In-Call StatusBar mode #86

Merged
merged 2 commits into from
Jun 29, 2017

Conversation

muukii
Copy link
Contributor

@muukii muukii commented Jun 29, 2017

When In-Call StatusBar Mode, UIPageViewController will have Top-margin.
I've moved pinToSuperviewEdges after addSubview.

But, pinToSuperviewEdges always guard-return in existing code.
Do you have any reasons for it?

I've attached screenshots below.
What do you think?

Before

ViewTree has double top-margin.

screen shot 2017-06-29 at 15 05 46

After

ViewTree has single top-margin.

screen shot 2017-06-29 at 15 06 45

simulator screen shot jun 29 2017 15 10 25

@msaps msaps changed the base branch from master to develop June 29, 2017 07:45
@msaps
Copy link
Member

msaps commented Jun 29, 2017

@muukii this was definitely a bug introduced in a recent version. Looks like the page view controller wouldn't have been constrained at all, the autoresizing masks will have masked it to a point.

The guard in the pinToSuperviewEdges masked this issue, as the application would have crashed trying to add a constraint with no superview. I'll get this in, and remove the guard.

Thanks! 👍

@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #86 into develop will increase coverage by 1.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #86      +/-   ##
==========================================
+ Coverage    67.21%   68.6%   +1.38%     
==========================================
  Files           20      20              
  Lines         1031    1032       +1     
==========================================
+ Hits           693     708      +15     
+ Misses         338     324      -14
Impacted Files Coverage Δ
.../Extensions/PageboyViewController+Management.swift 86.48% <100%> (+0.12%) ⬆️
Sources/Pageboy/Utilities/UIView+AutoLayout.swift 89.47% <0%> (+73.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c64ed2...8e26732. Read the comment docs.

@msaps msaps merged commit 5bf9768 into uias:develop Jun 29, 2017
@msaps
Copy link
Member

msaps commented Jun 29, 2017

Now available in 1.3.3 🎉

@muukii
Copy link
Contributor Author

muukii commented Jun 29, 2017

@msaps Wow, It's good! Thank you!

@msaps
Copy link
Member

msaps commented Jun 29, 2017

@muukii thank you for helping out! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants