-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lines in multi-line literal strings trimmed incorrectly #68
Comments
It looks like there's a test that contradicts the specification in @BurntSushi's tests. In particular, this test with this expected result. @avakar doesn't have a test case for this. I've fixed this issue in the Python script and will submit a PR. I believe @BurntSushi's test case is incorrect. Edit: Actually, both the |
Previously, the library would trim all whitespace in multiline strings, even when the string was a multiline _literal_ string. This resolves that issue, leaving all whitespace in multiline literal strings.
Previously, the library would trim all whitespace in multiline strings, even when the string was a multiline _literal_ string. This resolves that issue, leaving all whitespace in multiline literal strings.
Indentation is also gone if inserted as a multiline string. See #71 |
From the spec:
Closing as WONTFIX due to compliance with the spec. |
@uiri That line of the spec is entirely irrelevant to this issue. |
@uiri I totally aggree with @SergioBenitez |
I'm sorry. You're right; it is relevant to the associated PR(s) but not to this issue. |
Previously, the library would trim all whitespace in multiline strings, even when the string was a multiline _literal_ string. This resolves that issue, leaving all whitespace in multiline literal strings.
The library is incorrectly parsing/generating code from multi-line literal strings by condensing multiple new lines in the string into a single one.
Example:
EXPECTED:
ACTUAL:
We expect two new lines between
world
andbye
, but we get one. According to the specification (emphasis mine):I'll take a look at the code and propose a fix.
The text was updated successfully, but these errors were encountered: