Update (almost) all the things #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub is reporting current "requests" as insecure. Requires.io is reporting "lxml" as insecure. This updates both to the latest patched versions.
These aren't insecure but are outdated. Updates all test requirements to latest version, *except* Selenium, which we have pinned to a version known to work on Heroku. Also removed "Click" from test requirements as it is in the main requirements file too anyway (and is a dependency of one of the packages there).
* Black formatting * Pytest has tweaked fixture initialisation so now need to push app context in the `db` fixture
With the latest version of pytest this now raises a warning (to be an error in the next release of pytest). I've left the mock_user fixture here as it is useful for parametrized tests.
This mirrors the existing logged_in_rdu_user
When form is posted we shouldn't be populating the WTForms object with the existing object - we only pass the existing object in for the GET route, so that fields can be pre-populated in the displayed page.
* "chrome_options" is deprecated in favour of "options" * fixtures (in this case stub_measure_data) should not be called directly * wheel installation of psycopg2 package will be psycopg2-binary in future
TheDoubleK
force-pushed
the
update-insecure-requirements
branch
3 times, most recently
from
53a06bd to
32a14e3
Compare
Updating to the latest pytest resulted in the functional tests failing in our CI environment on Heroku - but not locally - with the error: `psycopg2.OperationalError: SSL error: decryption failed or bad record mac` Rolling back the version of pytest and related dependencies until we can figure out what the issue is. NOTE: have tried pytest 3.6.0 and that is broken with the same error.
TheDoubleK
force-pushed
the
update-insecure-requirements
branch
from
4cc0582 to
7583335
Compare
…uirements Resolved conflicts in: application/cms/views.py
|
@samuelhwilliams @frankieroberto I have had a pretty thorough click round the review app for this as I was a bit worried about bumping so many versions at once, but everything loks good as far as I can tell. |
frankieroberto
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this ticket: https://trello.com/c/dck7VGe3/1152-update-insecure-dependencies
This updates all our requirements other than Selenium to the latest versions (Selenium is pinned to the last version known to work on Heroku, and the last time I checked the latest version hasn't fixed the problem).
I've been having some odd intermittent failures of the functional tests locally against this branch, so it would be good if people can pull this down and try it out (also, let's see what CI makes of it now).
UPDATE CI seems to hate it 🤦♂️
UPDATE 2 Maybe not... it was mismatched Black formatting
UPDATE 3 CI really hates it... what the heck is
psycopg2.OperationalError: SSL error: decryption failed or bad record mac??There are few minor test and code changes here to get things working with these updated packages:
Also what I think is a larger genuine bug-fix that has been masked up until now by an issue in ealier version of WTForms: